Add ValidationException to error closures of operations of event stream#2861
Closed
jasgin wants to merge 1 commit intosmithy-lang:mainfrom
Closed
Add ValidationException to error closures of operations of event stream#2861jasgin wants to merge 1 commit intosmithy-lang:mainfrom
jasgin wants to merge 1 commit intosmithy-lang:mainfrom
Conversation
Contributor
|
This pull request does not contain a staged changelog entry. To create one, use the Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See |
joewyz
previously approved these changes
Nov 19, 2025
Contributor
|
This error is not part of the spec and only needed by the Rust SDK. The recommendation is for the Rust SDK to remove this requirement and align to what other SDKs implement. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The event stream protocol test operations take constrained input, but do not have
ValidationExceptionin the error closures. This is causing failures in CI for smithy-lang/smithy-rs#4399.Testing
Tests pass with the changes in place locally.
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.